Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: ns/fix/fuels dev node cleanup #3530

Closed
wants to merge 10 commits into from
Closed

test: ns/fix/fuels dev node cleanup #3530

wants to merge 10 commits into from

Conversation

petertonysmith94
Copy link
Contributor

Summary

  • Testing for failure

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

nedsalk and others added 7 commits November 22, 2024 13:13
@nedsalk
fix:
c187c5e 
✅ Your fuels version is up to date: 0.97.0

Config file not found! cleanup not killing node
@nedsalk
fix missing FORC_PATH
1b81f2a
@nedsalk @github-advanced-security
Fix code scanning alert no. 78: Shell command built from environment …
05f3dec 
…values

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@nedsalk
fix test
0c11d3b
@nedsalk
add explanatory comment
3f525ce
@petertonysmith94
chore: resync launchNode with master
8e6d084
@petertonysmith94
Merge branch 'master' of github.com:FuelLabs/fuels-ts into ps/test/ns…
e2998d8 
…/fix/fuels-dev-node-cleanup
@petertonysmith94 petertonysmith94 self-assigned this Jan 3, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 10:58am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 10:58am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 10:58am

@petertonysmith94
Copy link
Contributor Author

Closed PR as was only for testing purposes

@petertonysmith94 petertonysmith94 deleted the ps/test/ns/fix/fuels-dev-node-cleanup branch January 6, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm Awaiting requested review from digorithm digorithm will be requested when the pull request is marked ready for review digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya will be requested when the pull request is marked ready for review arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf will be requested when the pull request is marked ready for review Torres-ssf is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate will be requested when the pull request is marked ready for review danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk will be requested when the pull request is marked ready for review nedsalk is a code owner

@maschad maschad Awaiting requested review from maschad maschad will be requested when the pull request is marked ready for review maschad is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petertonysmith94 @nedsalk